-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avatars are being deleted after thumbnail regenarting #31
Comments
@ituk I believe they should be regenerated on demand when that specific size is requested; are you seeing broken avatar images on your site or just that specific file sizes are missing in your "uploads" folder? |
thanks @jeffpaul, but i only see broken avatars. i managed to restore most avatars from a backup i had, but i guess the core of the issue is still there. |
@ituk thanks for the update. Mind confirming your environmental info to help us triage this and aim for a resolution in the 2.2 milestoned release? Environment information
|
Environment information
|
I can reproduce this problem. The cropped avatars get deleted by Regenerate Thumbnails but the
This will do the trick. By registering an image size, the avatar will get regenerated like other image sizes. Btw, we still need a way to clear the avatar cache (saved as user meta). |
@dinhtungdu as we're still working on crafting the approach here, I'm going to move this out of the current milestone so we can move more quickly towards releasing version 2.2.0. |
I'm also running into the issue of missing profile image. Try to implement a way to catch this before user start complaining. Is there some way to do this? I try to call something like: string(257) "<img alt='Avatar for ' title='Gravatar for ' src='http://2.gravatar.com/avatar/?s=70&d=mm&r=g' srcset='http://0.gravatar.com/avatar/?s=140&d=mm&r=g 2x' class='avatar avatar-70 photo avatar-default' height='70' width='70' loading='lazy'/>" |
Hi @dinhtungdu I am starting to look into it, I am not getting where the image sizes are coming from to add it as an image size so it is generated on regenerate, also what changes is the |
@thrijith I'm sorry for this late reply! The avatars are generated on the fly so there isn't any image size to register. The cropped avatar URL is stored as the user metadata. After regenerating thumbnails, all thumbnails are deleted including ones cropped by Simple Local Avatar. But the URLs in the user meta aren't deleted, that's why we have the broken avatars. The idea behind the |
after regenerating all thumbnails in site and wiping unnecessary images (using Regenerate Thumbnails plugin), some avatars thumbnail where deleted. so...
The text was updated successfully, but these errors were encountered: