Test against WP 5.3

[jeffpaul]

Is your enhancement related to a problem? Please describe.
Now that WordPress 5.3 is released, we'll want to test Simple Local Avatars to see if any incompatibility issues arise.

Describe the solution you'd like

• test Simple Local Avatars on WP 5.3
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release, otherwise use "Plugin asset/readme update" action to update "tested up to" version on .org repo

Designs
n/a

Describe alternatives you've considered
none

Additional context
none

[Waka867]

@jeffpaul I will go through this and do some testing asap

[jeffpaul]

Much appreciated @Waka867, thank you!

[Waka867]

@jeffpaul I've run through each feature on a WP5.3 install and everything looks good. I'm a bit newer so I just want to double check to make sure I understand a few things:

• I will need an SVN account in order to use the readme update action?

I've created the following workflow although I did not hit commit yet:

name: Update Plugin / Deploy to Wordpress

on: [push]

jobs:
build:

runs-on: ubuntu-latest

steps:

• name: WordPress Plugin Deploy
  uses: 10up/action-wordpress-plugin-deploy@1.4.0

Thanks for the assistance. I just want to make sure I'm following protocol.

[jeffpaul]

@Waka867 if you're not seeing any issues after testing against WP 5.3, then feel free to submit a PR that updates that value in readme.txt. I'll worry about updating the GitHub Action to ensure this propagates to WordPress.ORG correctly, thanks!

[Waka867]

@jeffpaul Request entered. If you are able to give a general explanation of how you ended up using the Github action that would be great!

Pull Request

[jeffpaul]

@Waka867 I created #37 to update the formatting of our GitHub Actions to the current YML format. You can read more about our actions here: https://10up.com/blog/2019/wordpress-github-actions-streamline-plugin-deployment/.

I'm waiting on a review for #37, once that's merged in I'll look to merge #36 so we can trigger the auto-deploy to .ORG for the "tested up to" value.

Thanks again for your help on this!

[Waka867]

@jeffpaul No problem

[jeffpaul]

Huh, I assumed #38 getting merged would trigger the GitHub Action and deploy the readme.txt change to .ORG. Not seeing that in the Actions tab, will have to investigate what's going on there.

[dinhtungdu]

Currently, we don't have "new" GitHub actions configuration files on the master branch, so the asset doesn't get deployed. Adding actions config to the master branch will likely solve this issue. :)
See: https://github.com/10up/simple-local-avatars/tree/master/.github

[jeffpaul]

Closed by #38