Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player enhancements #191

Closed
1 of 11 tasks
jeffpaul opened this issue Oct 20, 2022 · 6 comments · Fixed by #272
Closed
1 of 11 tasks

Player enhancements #191

jeffpaul opened this issue Oct 20, 2022 · 6 comments · Fixed by #272
Assignees
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Oct 20, 2022

Is your enhancement related to a problem? Please describe.

The existing player that is used with the plugin is the default core audio player with no additional enhancements even with various toggles/metadata set in the podcast block settings:
Screen Shot 2022-10-20 at 10 27 00 AM

It might be nice to enhance the player to support the following functions:

Open to any/all of these items to roll into their own PR, best to update each item above with any linked PR # at the end of the line to better track completion of the work.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted Extra attention is needed labels Oct 20, 2022
@jeffpaul jeffpaul added this to the Future Release milestone Oct 20, 2022
@Sidsector9 Sidsector9 self-assigned this Nov 20, 2022
@jeffpaul
Copy link
Member Author

@Sidsector9 I'm unassigning you here as there doesn't appear to be a WIP PR, so moving this out for others to pick up and work on

@jayedul jayedul self-assigned this Jun 17, 2023
@jeffpaul
Copy link
Member Author

Some good examples in https://wordpress.org/plugins/podcast-player/

@jayedul
Copy link
Contributor

jayedul commented Jul 13, 2023

best to update each item above with any linked PR # at the end of the line

@jeffpaul I think implementing the whole checklist in a single PR will be more maintainable. Because these content's should be organized in a single wrapper element and design structure.

@jeffpaul
Copy link
Member Author

@jayedul if you've got the time and interest, go for it!

@jeffpaul
Copy link
Member Author

@gusaus
Copy link

gusaus commented Jun 21, 2024

Quick followup on the prior art on WAMU's site referenced in #299

In addition to the player being persistent, the ability to play on-demand podcasts AND live radio streams is key. Not sure if that would make sense for a plugin focused on podcasting, but possibly as a stand-alone persistent audio player?

Either way, we'd like to include the plugin and the persistent player(s) in the Newspack branches maintained by OpenProducer (see OpenProducer/newspack-platform#22) and would love to contribute/help where we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Archived in project
5 participants