Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude build files #6

Open
tlovett1 opened this issue Oct 19, 2017 · 2 comments
Open

Exclude build files #6

tlovett1 opened this issue Oct 19, 2017 · 2 comments

Comments

@tlovett1
Copy link
Member

node_modules, bower_components, and vendor are currently being included in snapshots. These files really slow things down.

@bengreeley
Copy link

Bumping this. Noticed when I installed a relatively small snapshot (20MB) with a simple theme and simple plugins it took 20 minutes to install the snapshot, which is way too long, especially if we want to use snapshots in a CI pipeline for WPAcceptance. Definitely seems like node_modules and vendor folders are slowing things down If I have time I'll take a look and see if I can make an update here.

@bengreeley
Copy link

bengreeley commented Jun 25, 2021

@tlovett1 Logic for ignoring build folders included in #89
The only thing that is different from the original request is I didn't exclude vendor folders by default. The reason for which is many times the vendor folders are required for websites to function, so people would need to track down all the folders with composer.json files and run composer install before they can run the site (think of plugins like Yoast that have very robust vendor folders). We can include it so it only excludes the topmost vendor folder, but again, the engineer would need to run composer install before using the site. I'd recommend we look into that separately, as those PHP files usually aren't as large as node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants