Allow missing outputPath when running under Serverless #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the bundle transform function, allowing
page.outputPath
to be falsy when running under Eleventy Serverless.This fixes an issue that causes placeholder strings to be rendered in Eleventy Serverless responses.
Details & Context
When using the shipping version of the bundler plugin in an Eleventy Serverless context, placeholder values are unexpectedly rendered to the resulting page. For example:
results in an un-transformed placeholder rendered in the response:
<!-- Here comes a bundle result! --> /*__EleventyBundle:get:html:head-preconnect:EleventyBundle__*/
This appears to be the result of the test for
page.outputPath
:eleventy-plugin-bundle/eleventy.shortcodes.js
Lines 63 to 66 in 5a95ce2
which is
false
when the page is rendered by Eleventy Serverless:Removing that check when running under Serverless — leaving only the test of whether
content
is a string — results in placeholder replacement by the plugin transform, as expected.