Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import EleventyShortcodeError into RenderPlugin.js #2577

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Import EleventyShortcodeError into RenderPlugin.js #2577

merged 1 commit into from
Dec 5, 2022

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Sep 26, 2022

This fixes the following error, which obscures the actual issue causing an error to be thrown.

[11ty] Unhandled rejection in promise: (more in DEBUG output)
[11ty] EleventyShortcodeError is not defined (via ReferenceError)
[11ty] 
[11ty] Original error stack trace: ReferenceError: EleventyShortcodeError is not defined
[11ty]     at /path/to/project/node_modules/@11ty/eleventy/src/Plugins/RenderPlugin.js:225:21
[11ty]     at processTicksAndRejections (node:internal/process/task_queues:96:5)

@zachleat zachleat merged commit 65de5ff into 11ty:master Dec 5, 2022
@zachleat zachleat added this to the Eleventy 2.0.0 milestone Dec 5, 2022
zachleat added a commit that referenced this pull request Dec 5, 2022
@zachleat
Extra from #2577
3cae349
zachleat added a commit that referenced this pull request Dec 5, 2022
@zachleat
One more extra from #2577
350cccc
@zachleat
Copy link
Member

zachleat commented Dec 5, 2022

Thank you! This will ship with 2.0.0-canary.19. I did fix this also in an earlier canary, but your code was a little cleaner 🏆

@j-f1 j-f1 deleted the eleventyshortcodeerror-not-defined branch December 6, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Eleventy 2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@j-f1 @zachleat