[Ethan] Xhr page requests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved duplicate assets that were in assets/images, since they are in assets/javascripts and can be found if we pass WYMEditor the right path (and make sure they can be precompiled).
… tandem.js and make the popup layout use tandem.js
…ndem bundle and therefore WYMEditor's auto path compute methods fail, since it can't find a script tag it thinks it should expect.
|
Note. This was branched off the precompile_branch, hence the duplicated commits. |
|
makes sense, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that multiple events were firing on some of the page requests, create/update. I realized that since these are now being loaded via ajax into colorbox, the application.js/tandem.js was being loaded every time we loaded a new page form into the colorbox. Now, we just don't include the layout if it's an xhr request.