This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I'm building the logOn message correctly yet, it logons on Steam without problems, but maybe something is missing, I need do more testing before it can be merged.
In the mean while I have a question:
On the Node library the SteamID Instance for the anonymous account is
ALL
where in this library isUnknown
, on the C# library it'sAll
as well, maybe it sould be calledAllInstance
to match the others libraries?https://github.com/DoctorMcKay/node-steamid/blob/4cbc98c2723ea92eba021a937dd9c7ae033ebe3f/index.js#L31
https://github.com/SteamRE/SteamKit/blob/master/SteamKit2/SteamKit2/Types/SteamID.cs#L72