old readme was not working anymore, this is minimal but works #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JWPapi thank you very much for your Pull Request. I have not merged it though because you've (accidentally?) removed other part of the code in the readme file that were fine. Instead I did fix it in the latest release v2.0.6 plus I have added the method getExchangeRatesV1. Feel free to give me any feedback about it |
|
Yes that’s fine. I assumed you’ll do this. I was in a rush and just wanted
to be helpful and didn’t check the other code examples.
Am Fr., 17. Juni 2022 um 23:22 Uhr schrieb Vincent HETRU <
***@***.***>:
… Hi @JWPapi <https://github.com/JWPapi> thank you very much for your Pull
Request. I have not merged it though because you've (accidentally?) removed
other part of the code in the readme file that were fine. Instead I did fix
it in the latest release v2.0.6 plus I have added the method
getExchangeRatesV1. Feel free to give me any feedback about it
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD77BIQT5VPAEAWXZ4FH4DVPTUBNANCNFSM5YW74XYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old readme was not working anymore I just made a basic code that returns the balance, so new users won’t have a bad experience.