Updating include syntax to support hasAndBelongsToMany relationships #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing some jshint errors.
|
Wow. You did a good job on rewriting this code. I see no problems after brief look. As for tests, I agree with you, test/include.js is proper place for checking this logic. Thanks! |
|
Okay, I got a simple test in there. Thanks for checking it out! |
|
Ping @1602 |
|
@1602 please review? |
1602
added a commit
that referenced
this pull request
Jun 21, 2014
Updating include syntax to support hasAndBelongsToMany relationships
|
THANKS! 💃 |
pocesar
pushed a commit
to pocesar/promised-jugglingdb
that referenced
this pull request
Jun 24, 2014
Updating include syntax to support hasAndBelongsToMany relationships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is a minimally invasive change to support hasAndBelongsToMany relationships when using the
includestyle syntax. I dangle an additional reference on the relation model,modelThroughand use that in the include logic; branching to a secondincludecall or to returning a normalmodelTo.allcallback.I also handled all the jshint errors I was getting in
lib/include.js.