Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modulize #2

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Modulize #2

merged 1 commit into from
Mar 17, 2020

Conversation

chihkaiyu
Copy link

Modulize this repo and fix tests.

@houjunchen
Copy link

Can you explain the change for test?

@chihkaiyu
Copy link
Author

chihkaiyu commented Mar 17, 2020 •
edited
Loading

Can you explain the change for test?

原本的 logrus 在 panic 時，是直接 panic(*Entry)，但我們為了看實際訊息，便 panic msg。aae516e

所以跑 panic test 時，一來 type 要從 *Entry 改成 string，二來要比對字串訊息。

@houjunchen houjunchen merged commit 723cd16 into 17media:panic-message Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houjunchen houjunchen houjunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chihkaiyu @houjunchen