support ENV import #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houjunchen
reviewed
Sep 21, 2018
cmd/root.go
Outdated
| GCPprojectID string | ||
| GCPlocationID string | ||
| GCPkeyRingID string | ||
| GCPcryptoKeyID string | ||
| Perfix string | ||
| ) | ||
|
|
||
| var CryptoTypeName = map[int32]string{ |
There was a problem hiding this comment.
How about just const string?
type CryptoType string
CryptoTypeText CryptoType = "text"
CryptoTypeEnv CryptoType = "env"
type Impoter func(args, perfix string) []Key
type Expoter func(keys []Key)
Impoters = map[CryptoType]Impoter{
CryptoTypeText: FlagsImporter,
CryptoTypeEnv: EnvsImporter,
}
Expoters = map[CryptoType]Expoter{
CryptoTypeText: FlagsExporter,
CryptoTypeEnv: EnvsExporter,
}
There was a problem hiding this comment.
This could reduct the number of if...else
2. modify Keys interface to Import(input []string, perfix string) []Key Export(keys []Key) 3. let encrypt() and decryt() determine the input while calling keys.Import()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.