Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pa11y-ci #1924

Merged
merged 2 commits into from
Oct 14, 2016
Merged

Add pa11y-ci #1924

merged 2 commits into from
Oct 14, 2016

Conversation

gemfarmer
Copy link
Contributor

WIP
#1896

@mugizico Instead of waiting for Aidan to get to the concourse scanner, I thought we might consider solving this on our end first. With pa11y-ci I don't think it should take terribly long.

@gemfarmer
Copy link
Contributor Author

gemfarmer commented Oct 11, 2016

Remaining work before this branch is merged:

  • address hound's grievances (if they are reasonable)
  • remove comments in sitemap.xml
  • squash commits on branch. Refer to thoughtbot or dolores landingham git protocol
  • review and edit documentation that has been added. We might consider having @coreycaitlin @awfrancisco or @jamiealbrecht take a look, too!
  • show @stvnrlly and add potentially make an issue in the pa11y-crawl and continua11y repo about CI alternatives.
  • make note in concourse-compliance-testing repo.

Copy link

@mugizico mugizico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled and scanned locally on my machine. 382 of 382 URLs passed.

@mugizico
Copy link

@gemfarmer the squashed commits could use some re-wording for clarity. Let's chat about it sometimes...

@gemfarmer gemfarmer merged commit 35e9fdd into dev Oct 14, 2016
@gemfarmer gemfarmer deleted the pa11y-ci-new branch October 14, 2016 17:00
@@ -81,12 +81,12 @@ they defeat the purpose of a unified user experience.
The Newbie is a designer or front end developer who is new to government
and early in their career.

#### Who they are
<h4 id="who-they-are-2">Who they are</h4>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elainekamlley this is an example of how we fixed the multiple header error

@gemfarmer
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants