Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: get pa11y running in CircleCI again #3779

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix: get pa11y running in CircleCI again #3779

merged 1 commit into from
Oct 25, 2023

Conversation

echappen
Copy link
Contributor

Pull request summary

  • Adds a chromium headless browser config to get pa11y scanning urls in CircleCI job post ruby 3 upgrade
  • Also bust dependency caches for ruby and node from the ruby 3 upgrade

Closes #3773

@echappen
Fix: add chrome launch config to get pa11y running in CircleCI
752a765 
Also bust dependency caches for ruby and node from the ruby-3 upgrade
@echappen echappen changed the title Fix: add chrome launch config to get pa11y running in CircleCI Fix: get pa11y running in CircleCI again Oct 24, 2023
@echappen echappen requested a review from a team October 24, 2023 19:48
kbighorse
kbighorse approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@kbighorse kbighorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 I am approving since it ran in CircleCI. There is a SIGHUP at the end of the run, though, just flagging here for posterity.

@echappen
Copy link
Contributor Author

Thanks! I'll write an issue to address the SIGHUP.

@echappen echappen merged commit cc8de31 into main Oct 25, 2023
2 checks passed
@echappen echappen deleted the eoc/fix-pa11y-ci branch October 25, 2023 13:52
@igorkorenfeld igorkorenfeld mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbighorse kbighorse kbighorse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: pa11y scans failing on site
2 participants
@echappen @kbighorse