Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code block styling on 18f blog #3851

Merged
merged 1 commit into from
Jun 7, 2024
Merged

add code block styling on 18f blog #3851

merged 1 commit into from
Jun 7, 2024

Conversation

peterrowland
Copy link
Member

Pull request summary

Add some style rules to differentiate code blocks from regular text and to wrap text so it doesn't overflow.

(Optional) Closes #(issue_number).
#3824
#3823

Reminder - please do the following before assigning reviewer

  • For frontend changes, ensure design review

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introduced

@peterrowland peterrowland requested a review from a team as a code owner June 4, 2024 17:09
@cantsin
Copy link
Member

cantsin commented Jun 4, 2024

Yay! Thank you. Flagging that we are moving 18f.gsa.gov to 11ty and wanted to make sure this wasn't lost in the noise. @beechnut -- OK to merge or do we wait to merge till post-migration?

@melchoyce
Copy link
Member

For design review, could we grab a before/after screenshot? 👀

@peterrowland
Copy link
Member Author

peterrowland commented Jun 4, 2024

Here is an example from a blog post of before and after:

before
link
after
link

@peterrowland
Copy link
Member Author

This adds styling to a pre highlight element that contains the code block. As far as I know, these blocks only appear in a handful of entries that use the ``` markdown around code blocks. Would appreciate If someone who knows the website and USWDS better than me could sign off on adding the right rules in the right place.

@melchoyce
Copy link
Member

LGTM on the design side 👍

Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cantsin cantsin merged commit 9ce2dc6 into main Jun 7, 2024
5 checks passed
@cantsin cantsin deleted the add-code-highlighting branch June 7, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants