This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
86661892 notifications include comments #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay only the full_name in main cart template
| </tr> | ||
| <% end %> | ||
| </table> | ||
| <% end %> |
There was a problem hiding this comment.
Still feeling like it's not worth duplicating the markup for displaying cart details...
|
Mind posting a screenshot? |
|
This could probably use a couple of alignment tweaks before merging this in. |
| <p class='comment-sender col-sm-6 col-xs-12'> | ||
| <strong>requester@test.com</strong> | ||
| </p> | ||
| <% unless c.user.nil? %> |
There was a problem hiding this comment.
is this "unless" actually needed?
|
Updated with some minor alignment adjustments
|
|
Last bit of tweaks for now.
|
afeld
added a commit
that referenced
this pull request
Feb 6, 2015
86661892 notifications include comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple display of comments to the top of notification emails. Will revisit layout with #85453096 since original mockups didn't account for comments.