Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

[#Delivers 98973752] Use default puma/newrelic config as it works out of the box #472

Merged
merged 2 commits into from
Jul 14, 2015

Conversation

cmc333333
Copy link
Contributor

We had a configuration that worked for an older version of the newrelic gem; according to the current docs this is no longer required.

Tested by pushing to staging; started logging almost immediately.

@afeld
Copy link
Contributor

afeld commented Jul 13, 2015

Did you try running this? Didn't work for me, despite that it supposedly should:

puma/puma#614 (comment)

@cmc333333
Copy link
Contributor Author

Yep, both on staging and locally:

vagrant@debian8:~/C2$ git status
On branch 98973752-newrelic-monitoring
nothing to commit, working directory clean
vagrant@debian8:~/C2$ rails s -b 0.0.0.0 -p8080
=> Booting Puma
=> Rails 4.2.3 application starting in development on http://0.0.0.0:8080
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Puma 2.11.3 starting...
* Min threads: 0, max threads: 16
* Environment: development
* Listening on tcp://0.0.0.0:8080

@afeld
Copy link
Contributor

afeld commented Jul 14, 2015

Ah, I remember now – try bundle exec puma. This is the command we need to have Cloud Foundry use, because rails server ignores the Puma config file.

@afeld
Copy link
Contributor

afeld commented Jul 14, 2015

Ok, just tested both ways – the warning doesn't seem to cause any issues. Thanks!

afeld added a commit that referenced this pull request Jul 14, 2015
[#Delivers 98973752] Use default puma/newrelic config as it works out of the box
@afeld afeld merged commit 5b140c0 into master Jul 14, 2015
@afeld afeld deleted the 98973752-newrelic-monitoring branch July 14, 2015 03:02
@cmc333333
Copy link
Contributor Author

For the curious, I also don't get a warning when running puma directly:

vagrant@debian8:~/C2$ bundle exec puma -p8080
[30795] Puma starting in cluster mode...
[30795] * Version 2.11.3 (ruby 2.2.2-p95), codename: Intrepid Squirrel
[30795] * Min threads: 5, max threads: 5
[30795] * Environment: development
[30795] * Process workers: 1
[30795] * Preloading application
[30795] * Listening on tcp://0.0.0.0:8080
[30795] * Listening on tcp://0.0.0.0:3000
[30795] Use Ctrl-C to stop
[30795] - Worker 0 (pid: 30798) booted, phase: 0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants