[Feature] Handle small/zero metric values in charts

18F · Jun 28, 2024 · 87bebba · 87bebba
1 parent cb47f25
commit 87bebba
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/assets/bundle.js b/assets/bundle.js
diff --git a/js/components/main_charts/RealtimeVisitors.js b/js/components/main_charts/RealtimeVisitors.js
@@ -29,7 +29,9 @@ function RealtimeVisitors({ dataHrefBase, agency }) {
         .call(
           renderBlock.loadAndRender().render((selection, data) => {
             const totals = data.data[0];
-            selection.text(formatters.addCommas(+totals.active_visitors));
+            selection.text(
+              totals ? formatters.addCommas(+totals.active_visitors) : 0,
+            );
           }),
         );
       return result;

diff --git a/js/components/main_charts/TopCountriesRealtime.js b/js/components/main_charts/TopCountriesRealtime.js
@@ -42,10 +42,13 @@ function TopCountriesRealtime({ dataHrefBase }) {
               }
             });
             const international = totalVisits - USVisits;
-            const data = {
-              "United States &amp; Territories": USVisits,
-              International: international,
-            };
+            const data = {};
+            if (USVisits) {
+              data["United States &amp; Territories"] = USVisits;
+            }
+            if (international) {
+              data["International"] = international;
+            }
             return transformers.findProportionsOfMetricFromValue(
               transformers.listify(data),
             );