Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 714: Group US territories under United States #723

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Issue 714: Group US territories under United States #723

merged 3 commits into from
Oct 21, 2020

Conversation

echappen
Copy link
Contributor

@echappen echappen commented Oct 21, 2020 •
edited by tdlowden
Loading

Summary

Resolves Issue #714

  • Groups US territories under bar chart "United States & Territories" (listed in js/lib/territories.js)
    • This group is limited to 3 (United States and two other top performing territories)
  • Removes US territories from International bar chart grouping
  • Adds more cities to the list on the left to balance whitespace

Notes

  • I tried the name "United States and US Territories" but that got too truncated

Screenshot

Screen Shot 2020-10-21 at 9 51 30 AM

This pull request is ready to merge when...

  • Tests have been updated (and all tests are passing)
  • This code has been reviewed by someone other than the original author
  • The change has been documented

@echappen
WIP: initial sub-list for US territories
65b769a 
#714

Pending:
- Final titles for bar charts and items
- Possible filtering of territories and/or countries
@echappen
Even out white space around cities and countries bar charts
ca862ce 
Relates to #714
@echappen
Refactor inclusion in US for browser compatability
f18a227 
Related to GH issue #714
@echappen echappen requested review from tdlowden and ryanhofdotgov and removed request for ryanhofdotgov October 21, 2020 15:43
tdlowden
tdlowden approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@tdlowden tdlowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amaze.

@tdlowden tdlowden merged commit 92fe548 into master Oct 21, 2020
@tdlowden tdlowden mentioned this pull request Oct 21, 2020
Closed
@ryanwoldatwork ryanwoldatwork deleted the 714-add-us-territories branch April 6, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdlowden tdlowden tdlowden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echappen @tdlowden