Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-umbrella-router deployment process needs to rebuild templatized config files #161

Closed
GUI opened this issue Dec 11, 2014 · 1 comment
Closed

Comments

@GUI
Copy link
Member

GUI commented Dec 11, 2014

When we deploy the individual API Umbrella components to our servers (see #159), we reload various processes on the server after the deployment completes so the new code is activated. This is all working fine for all our code changes, however one thing I just bumped into is the fact that some of our template config files don't get rebuilt during this reload process after deployments. This can lead to a deployment of that component being somewhat incomplete, since any changes to template config files won't be re-read until a full restart of API Umbrella.

For reference, I made this change related to #128: NREL/api-umbrella-router@4d7e494 This was a one line change to templates/etc/nginx/router.conf.hbs, but it didn't actually go live after the deployment since the generated config file sitting in /opt/api-umbrella/etc/nginx/router.conf didn't get regenerated from the new template. So even though the deployment process reloaded nginx to pick up potential config file changes, the changes weren't present.

This might be as simple as calling writeTemplates during the reload process, but I need to investigate a bit more.

@GUI GUI added the bug label Dec 11, 2014
GUI added a commit to NREL/api-umbrella-router that referenced this issue Jan 26, 2015
This fixes templates not being rewritten during deploys, so template
changes were not being reflected.

See 18F/api.data.gov#161
@GUI GUI added this to the Sprint 13 (1/12-1/23) milestone Jan 26, 2015
@GUI
Copy link
Member Author

GUI commented Jan 26, 2015

This should be fixed by NREL/api-umbrella-router@963320e and NREL/api-umbrella-router@b31963e We also needed to rebuild the YAML config file on reload to pickup potential YAML config file change.

@GUI GUI closed this as completed Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant