Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin accounts should treat e-mails case insensitively #170

Closed
GUI opened this issue Jan 15, 2015 · 1 comment
Closed

Admin accounts should treat e-mails case insensitively #170

GUI opened this issue Jan 15, 2015 · 1 comment
Assignees
@GUI
Labels
api-umbrella-v0.7 enhancement
Milestone
Sprint 13 (1/12-1...

Comments

@GUI
Copy link
Member

GUI commented Jan 15, 2015

Today we hit a stumbling block with a new admin user that wasn't able to login. It turned it was because the e-mail address they were logging in was using uppercase characters, while I had added the e-mail to our admin database as all lowercase. We should make the admin login e-mails case-insensitive so this is less error prone.
@GUI GUI self-assigned this Jan 15, 2015
GUI added a commit to NREL/api-umbrella-web that referenced this issue Jan 18, 2015
@GUI
Allow admin logins to be case-insensitive. Fix GitHub oauth login.
5a7a928 
Also add some basic tests around the omniauth login stuff.

Related to case-insensitive logins:
18F/api.data.gov#170

Related to GitHub issues:
NREL/api-umbrella#46
NREL/api-umbrella#88
@GUI GUI added this to the Sprint 13 (1/12-1/23) milestone Jan 19, 2015
@GUI
Copy link
Member Author

GUI commented Jan 19, 2015

This should be fixed in NREL/api-umbrella-web@5a7a928 Now the case of the e-mail doesn't matter for admins logging in.

@GUI GUI closed this as completed Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GUI GUI

Labels
api-umbrella-v0.7 enhancement
Projects
None yet
Milestone
Sprint 13 (1/12-1/23)
Development

No branches or pull requests
1 participant
@GUI