Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github auth "invalid credentials" #88

Closed
bragan opened this issue Jan 13, 2015 · 2 comments
Closed

Github auth "invalid credentials" #88

bragan opened this issue Jan 13, 2015 · 2 comments
Milestone

Comments

@bragan
Copy link

bragan commented Jan 13, 2015

I have api-umbrella up and running and now trying to configure admin auth.

I have the yaml file configured correctly as far as i can tell and also have added the app to github as shown on the api-umbrella wiki.
web:
admin:
initial_superusers:
-
auth_strategies:
github:
client_id:
client_secret:

When I click login with Github It directs me to the Github login page and I then get redirected to the callback url which takes me to an error page:
"We're sorry, but something went wrong.
We've been notified about this issue and we'll take a look at it shortly."

If i reload the page it sends me back to the api-umbrella login page which has this error message:
Could not authenticate you from GitHub because "Invalid credentials".

GUI added a commit to NREL/api-umbrella-web that referenced this issue Jan 18, 2015
Also add some basic tests around the omniauth login stuff.

Related to case-insensitive logins:
18F/api.data.gov#170

Related to GitHub issues:
NREL/api-umbrella#46
NREL/api-umbrella#88
@GUI
Copy link
Member

GUI commented Jan 19, 2015

Sorry for the delay. I think I've discovered the underlying bug in our GitHub authentication handling. This should be fixed in master of the api-umbrella-web component. This will be included in our next package release (version 0.7), but that's currently unscheduled. If you'd like to deploy the changes now, you can do so by deploying the api-umbrella-web component from master. See Deploying From Git for further instructions on that.

@GUI GUI added this to the v0.7 milestone Jan 19, 2015
@GUI
Copy link
Member

GUI commented Jan 21, 2015

Since this should be fixed in master, I'm going to go ahead and close this, so we can keep better track of which issues are resolved or not in our milestones.

@GUI GUI closed this as completed Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants