This repository has been archived by the owner on Dec 30, 2017. It is now read-only.
deploy to GovCloud #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.3.1 was dropped from the buildpack, breaking the app. Better to just use the latest version than try and keep in sync with the explicit version that's available in the buildpack.
The new S3 broker provides the region in the credentials, whereas it needed to be specified explicitly before.
|
Ready for review! |
jcscottiii
approved these changes
Jan 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to 18F/concourse-compliance-testing#127. Pairing with @glbrtmrgn and @jcscottiii.
/cc https://github.com/18F/cg-migration/issues/18