Relationships - marital - location of marriage not saving - Data Persistence

[ryanhofdotgov]

From e-QIP-prototype-truetandem created by Jay-Neighbours-I72 : ryanhofdotgov/e-QIP-prototype-truetandem#2916

• Marriage location not saving

[bpdesigns]

The location of Marriage seems to be persisting now, but "Provide this person's country(ies) of citizenship" is not persisting

[ryanhofdotgov]

When I've read about these types of issues in the project's history it is usually because of a variable typo somewhere; e.g., part of the form calls it 'foobar' and some other layer calls it 'foo'

[bpdesigns]

Hey Ryan, do you think It's worth the time for me reviewing the data persistence issues?

…

On Wed, Jul 25, 2018 at 1:22 PM, Ryan Hofschneider ***@***.*** > wrote: When I've read about these types of issues in the project's history it is usually because of a variable typo somewhere; e.g., part of the form calls it 'foobar' and some other layer calls it 'foo' — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOnndGOkt3Im_v8-vxK0dodBt5ZOtpPGks5uKKlngaJpZM4ULTXR> .

-- Ben Peterson Experience Designer & Researcher 18F <https://18f.gsa.gov/> | GSA <http://www.gsa.gov/portal/category/100000>

[ryanhofdotgov]

What you've been doing so far has been great – reviewing issues of all kinds and verifying they are still reproducible. Persistence errors in particular are important (if there are still others), since they could prevent successful completion of form.

[afeld]

We can/should also make automated tests for this: fill out a section, refresh, and check that the data displayed is the same. Shouldn't be tooo hard.

[ryanhofdotgov]

Yup, totally agree – here's an outstanding related ticket #144 I asked TrueTandem to work on this before they got off contract, but they ran out of time. Once we finish the current iteration of getting the spec tests working, we should revisit.

[ryanhofdotgov]

This is likely some type of naming issue; i.e., form field is named XYZ one place and persistence logic is expecting it to be called xyZ. When we've seen this type of issue in the past, that's what its been.

[hursey013]

It appears that Provide the location of the marriage and Provide this person's country(ies) of citizenship are persisting when testing the app locally - can anyone else reproduce this persistence issue?

[ryanhofdotgov]

Yup, still happens for me unfortunately. Steps to reproduce, using Chrome's incognito window:

1. Sign in, expand Relationships, expand Marital & relationship status, click on Marital.
2. Click on "Currently in a civil marriage"
3. Scroll to Provide location. Click on Yes, in United States. Fill out City, State, County.
4. Scroll down to bottom of page, click on Save, even if it says it was already just Saved.
5. Log out, close window.
6. In new incognito window, sign in again, go to "Provide location" – no data appears in fields.