Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

process_a11y.py script is not factoring in domains with no errors but it should #103

Closed
gbinal opened this issue Dec 7, 2016 · 2 comments

Comments

@gbinal
Copy link
Member

gbinal commented Dec 7, 2016

In step 6 of the a11y scanning process, the process_a11y.py script is not factoring in domains that have no errors since it is just building from the results of the a11y.csv file generated in step 5, however it needs to.

Imagine an executive branch agency with three active, non-redirecting domains. After step 5 completes, there are only error results for two domains (either because the third domain did not scan successfully or because no errors were detected). The problem is that step 6 computes based on the a11y.csv file of individual error results and does not factor in the total domain set that it should be considering.

@gbinal
Copy link
Member Author

gbinal commented Feb 16, 2017

To elaborate, when the process_a11y.py script runs, it needs to do the following.

When creating the agencies.json file:

  • Average Errors per Page should be computed by [Sum of Errors]/[Number of Domains The Agency Has In Domains.csv] instead of what is currently the case, [Sum of Errors]/[Number of Domains The Agency Has In A11y.csv].
  • If an agency is represented in domains.csv but not in a11y.csv, an entry for it should still be created, with 0 for each of the error fields.

When creating the domains.json file:

  • If a domain is represented in domains.csv but not in a11y.csv, an entry for it should still be created, with 0 for each of the error fields.

@gbinal
Copy link
Member Author

gbinal commented Apr 3, 2017

@micahsaul's good work has resolved this so I'll close now.

@gbinal gbinal closed this as completed Apr 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant