-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Current coverage is
|
add migration for fiscal years
e9e9023
to
41973de
Compare
761821c
to
c5db223
Compare
a726551
to
dcae1db
Compare
OK, I think this is ready to review for merge. |
It seems like we could use additional test coverage around the load_opportunities command to ensure the right number of opportunities are loaded. |
# | ||
|
||
@staticmethod | ||
def parse_date(s): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that, in a prior review, we thought this could be replaced with strftime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but I don't see the benefit of that. The model currently uses Django's DateField for the estimated solicitation date, which takes a datetime.date
as an input. Do we want to change that field to a string?
7841270
to
a62037c
Compare
a62037c
to
38b819d
Compare
👍 |
This makes the following changes:
price_min
andprice_max
todollar_value_min
anddollar_value_max
, along with aninclude_options
field./manage.py load_opportunites
—to populate historical data on offices, opportunities, and advisors, which allows future use of that office data, as well