Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

Re-activate search bar #45

Merged
merged 3 commits into from
Feb 16, 2016
Merged

Re-activate search bar #45

merged 3 commits into from
Feb 16, 2016

Conversation

stvnrlly
Copy link
Member

Two things remain:

(1) We should discuss which fields should be included in the search. Should it be all of them or a subset?

(2) Using the search button only reloaded the page, so it is temporarily disabled. Is that a feature that we need? The search filters on the same page, so loading a results page isn't necessary, but perhaps users would want to share searches.

@codecov-io
Copy link

Current coverage is 90.55%

Merging #45 into develop will not affect coverage as of 941817d

@@            develop     #45   diff @@
=======================================
  Files             9       9       
  Stmts           360     360       
  Branches         17      17       
  Methods           0       0       
=======================================
  Hit             326     326       
  Partial           3       3       
  Missed           31      31       

Review entire Coverage Diff as of 941817d

Powered by Codecov. Updated on successful CI builds.

@ddotrollins
Copy link

Fields vendor said would be useful for them to search information by:

  • place of performance
  • Socioeconomic Category
  • Contract Type
  • NAICS codes
  • Title
  • Description
  • Competition Strategy
  • procurement opportunity (was referring to the amount)
  • POCs (don't think people search by this, they just appreciate this information)
  • Incumbent information (don’t think this is current available)

@stvnrlly
Copy link
Member Author

@lauraGgit when you have time, could you give a 👍 👎 on this? I think there are likely to be only minor tweaks beyond this point.

@lauraGgit
Copy link

It is working, but maybe not quite how we expected it to.

@stvnrlly
Copy link
Member Author

I'm merging this, but adding #47 to make sure we don't lose track of the outstanding question.

stvnrlly added a commit that referenced this pull request Feb 16, 2016
@stvnrlly stvnrlly merged commit de69ce9 into develop Feb 16, 2016
@stvnrlly stvnrlly deleted the feature/search-bar branch February 16, 2016 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants