-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pa11y-ci #25
Merged
Merged
Add pa11y-ci #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkorenfeld
requested review from
geekygirlsarah,
loganmeetsworld and
kewlguy781
July 11, 2023 18:53
Can we get some documentation about how to run this locally and in the CI? |
loganmeetsworld
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one request for documentation.
igorkorenfeld
force-pushed
the
ik/pa11y-setup
branch
from
July 13, 2023 19:07
fca85ce
to
08e09bc
Compare
igorkorenfeld
force-pushed
the
ik/pa11y-setup
branch
from
July 13, 2023 19:08
08e09bc
to
5f31fa3
Compare
igorkorenfeld
force-pushed
the
ik/pa11y-setup
branch
from
July 14, 2023 16:00
c55f444
to
6f8392c
Compare
igorkorenfeld
requested review from
kewlguy781
and removed request for
geekygirlsarah and
kewlguy781
July 17, 2023 16:23
kewlguy781
reviewed
Jul 17, 2023
kewlguy781
reviewed
Jul 17, 2023
kewlguy781
reviewed
Jul 17, 2023
kewlguy781
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR adds
pa11y-ci
automated a11y testing, and sets up the github action. In addition, the PR fixes the a11y bugs that the tests found so far.