Fix prose sibling heading margin selectors #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: It's assumed (confirmation needed) that the intention of these selectors was to match headings within
.usa-prose
following any other content in that prose block. Instead, due to the behavior of&
in expanding the full selector ancestry, the generated output was along the lines of...This can be interpreted as "a heading within a prose block, where the prose block itself is preceded by any other content".
This is expected to have a visual impact on headings in prose content. Example, from the "Typography" page:
Given that this styling has existed for quite a while, it may be worth reevaluating if the margins are still desirable.