Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-4226: Remove deprecated button variants #189

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 25, 2021

This is the first of a couple pull requests toward LG-4226, and includes only removal of button variants no longer supported in the design system.

These include:

  • Success (usa-button--success)
  • Dropdown (usa-button--dropdown)
  • Small (usa-button--small)
  • Tiny (usa-button--tiny)

See LG-4226 for more detail.

This is the first of a couple pull requests toward LG-4226, and includes only removal of button variants no longer supported in the design system.

These include:
  - Success (`usa-button--success`)
  - Dropdown (`usa-button--dropdown`)
  - Small (`usa-button--small`)
  - Tiny (`usa-button--tiny`)

See LG-4226 for more detail.
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Member Author

aduth commented Feb 25, 2021

Visual regression is exclusive to the buttons page and is expected based on removed content.

@aduth aduth merged commit e03de2a into main Feb 25, 2021
@aduth aduth deleted the aduth-lg-4226-rm-deprecated-buttons branch February 25, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants