Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Security experience link content #315

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

nickttng
Copy link
Member

@nickttng nickttng commented Jun 2, 2022

Proposal: To reflect the latest content from the upcoming Partners site. So that both sites are aligned.

Background context: The content changes were prompted by accessibility testing with the Partners site, which Chanan and Danielle have reviewed.

@nickttng nickttng requested review from juliaelman and aduth June 2, 2022 20:16
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Member

aduth commented Jun 6, 2022

The build failure is expected here, since the visual regression test caught the changed content. Should be fine to merge regardless.

https://app.circleci.com/pipelines/github/18F/identity-style-guide/1029/workflows/79103523-9374-4bf7-b5e6-88c6ee0b8d74/jobs/2770/artifacts

@nickttng nickttng merged commit 4540133 into main Jun 6, 2022
@nickttng nickttng deleted the nng-update-security-experience-content branch June 6, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants