Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Big" variant of Text Input, Textarea #326

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Dec 21, 2022

Adds new "Big" variants of Text Input and Textarea components to reflect Figma LGDS reference, and to support migration toward design system inputs in the IdP.

Live preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.sites.pages.cloud.gov/preview/18f/identity-style-guide/aduth-big-text-inputs/components/form-fields/

@aduth aduth requested a review from nickttng December 21, 2022 14:36
Copy link
Member

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both look good to me. Any particular feedback that you're looking for?

@aduth
Copy link
Member Author

aduth commented Dec 21, 2022

Both look good to me. Any particular feedback that you're looking for?

Nothing in particular! Unless you notice anything off between the specification and the implemented field.

@aduth
Copy link
Member Author

aduth commented Dec 22, 2022

Visual regression test failure is expected for the new documented examples:

image

@aduth aduth merged commit 41bfb21 into main Dec 22, 2022
@aduth aduth deleted the aduth-big-text-inputs branch December 22, 2022 14:20
@aduth aduth mentioned this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants