-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-13136: Fix rate limiting logic when user is on last try #10538
Closed
Commits on May 1, 2024
-
Fix rate limiting logic when user is on last try
When we used `limited?` we found the user was prevented from completing their last chance at a request, due to the `>=`, since the attempts and max_attempts were equal. Instead we needed a way to only prevent that if the user had exceeded their max amount of tries.
Configuration menu - View commit details
-
Copy full SHA for 6d97f55 - Browse repository at this point
Copy the full SHA 6d97f55View commit details -
In the previous commit, we were looking to prevent the `capture_doc_status_controller` from setting the rate limit too early. In this commit, we are instead removing the logic to even look at rate limiting here, since [as Dawei pointed out](#10538 (comment)), and as I found [a past discussion for](#9370 (comment)), this code should never be reached if rate limited.
Configuration menu - View commit details
-
Copy full SHA for 67569af - Browse repository at this point
Copy the full SHA 67569afView commit details -
changelog: User-Facing Improvements, Doc Auth, Fix rate limiting logi…
…c when user is on last try
Configuration menu - View commit details
-
Copy full SHA for bc1c63f - Browse repository at this point
Copy the full SHA bc1c63fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ee24a - Browse repository at this point
Copy the full SHA c3ee24aView commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a9891c5 - Browse repository at this point
Copy the full SHA a9891c5View commit details
Commits on May 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 043a3b3 - Browse repository at this point
Copy the full SHA 043a3b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bb3c34 - Browse repository at this point
Copy the full SHA 3bb3c34View commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cdc8919 - Browse repository at this point
Copy the full SHA cdc8919View commit details -
Configuration menu - View commit details
-
Copy full SHA for d147bee - Browse repository at this point
Copy the full SHA d147beeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfc3b31 - Browse repository at this point
Copy the full SHA bfc3b31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33e333b - Browse repository at this point
Copy the full SHA 33e333bView commit details
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 208a5b8 - Browse repository at this point
Copy the full SHA 208a5b8View commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 53dc047 - Browse repository at this point
Copy the full SHA 53dc047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a22735 - Browse repository at this point
Copy the full SHA 9a22735View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.