Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13136: Fix rate limiting logic when user is on last try #10538

Closed
wants to merge 14 commits into from

Commits on May 1, 2024

  1. Fix rate limiting logic when user is on last try

    When we used `limited?` we found the user was
    prevented from completing their last chance at a
    request, due to the `>=`, since the attempts and
    max_attempts were equal.
    
    Instead we needed a way to only prevent that if
    the user had exceeded their max amount of tries.
    night-jellyfish committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6d97f55 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary logic

    In the previous commit, we were looking to prevent the
    `capture_doc_status_controller` from setting the rate limit too early.
    
    In this commit, we are instead removing the logic to even look at rate
    limiting here, since [as Dawei pointed out](#10538 (comment)), and as I found [a past
    discussion for](#9370 (comment)), this code should never be reached if rate limited.
    night-jellyfish committed May 1, 2024
    Configuration menu
    Copy the full SHA
    67569af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc1c63f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c3ee24a View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. WIP

    night-jellyfish committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a9891c5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Configuration menu
    Copy the full SHA
    043a3b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bb3c34 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    cdc8919 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d147bee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bfc3b31 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    33e333b View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    208a5b8 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    53dc047 View commit details
    Browse the repository at this point in the history
  2. LG-13136: linter.

    dawei-nava committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9a22735 View commit details
    Browse the repository at this point in the history