Remove Attempts API code #10732
Merged
Remove Attempts API code #10732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added a commit
that referenced
this pull request
May 31, 2024
zachmargolis
approved these changes
May 31, 2024
aduth
added a commit
that referenced
this pull request
May 31, 2024
See: #10732 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
n1zyy
reviewed
May 31, 2024
aduth
added a commit
that referenced
this pull request
May 31, 2024
aduth
added a commit
that referenced
this pull request
Jun 3, 2024
aduth
added a commit
that referenced
this pull request
Jun 3, 2024
See: #10732 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
added a commit
that referenced
this pull request
Jun 3, 2024
aduth
force-pushed
the
aduth-rm-attempts-api
branch
from
c867fb4
to
d885ad9
Compare
changelog: Internal, Code Quality, Remove unused Attempts API code
See: #10732 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-rm-attempts-api
branch
from
d885ad9
to
cf7fa83
Compare
Merged
colter-nattrass
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Remove unused Attempts API code changelog: Internal, Code Quality, Remove unused Attempts API code * Revert query changes to exclude IRS Attempts API events See: #10732 (comment) * Inline rate_limit_reached with arguments See: #10732 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Revert adding ignored_columns for irs_attempts_api_enabled See: #10732 (comment) --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes code for the Attempts API, as it has stagnated unused for over a year, and is a source of additional maintenance burden, and at high risk of behaving unpredictably if ever enabled.
If needed in the future, it can be salvaged from git history.
See related Slack discussion: https://gsa-tts.slack.com/archives/C03KDV9S8T1/p1717163717684099
📜 Testing Plan
Verify build passes and there are no regressions in critical user flows.