Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Hotfix update deps #1517

Merged
merged 4 commits into from
May 30, 2017
Merged

Hotfix update deps #1517

merged 4 commits into from
May 30, 2017

Conversation

adelevie
Copy link
Contributor

No description provided.

@adelevie
Copy link
Contributor Author

Getting these errors:

Failures:

  1) SSO user is not an admin does not sign in the user
     Failure/Error: expect(response).to redirect_to('http://www.example.com/')
     
       Expected response to be a redirect to <http://www.example.com/> but was a redirect to <http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml>.
       Expected "http://www.example.com/" to be === "http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml".
     # ./spec/requests/sso_spec.rb:24:in `block (3 levels) in <top (required)>'

  2) SSO user is an admin uses external SAML IdP to sign in the user
     Failure/Error: expect(response).to redirect_to('http://www.example.com/admin/auctions/needs_attention')
     
       Expected response to be a redirect to <http://www.example.com/admin/auctions/needs_attention> but was a redirect to <http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml>.
       Expected "http://www.example.com/admin/auctions/needs_attention" to be === "http://www.example.com/auth/failure?message=invalid_ticket&strategy=saml".
     # ./spec/requests/sso_spec.rb:44:in `block (3 levels) in <top (required)>'

  3) SLO SP-initiated uses external SAML IdP
     Failure/Error: settings.name_identifier_value = current_user.uid
     
     NoMethodError:
       undefined method `uid' for #<Guest:0x0000000b592cd8>
     # ./app/controllers/saml_authentications_controller.rb:90:in `sp_logout_request'
     # ./app/controllers/saml_authentications_controller.rb:22:in `destroy'

@adelevie
Copy link
Contributor Author

closing in favor of #1519

@adelevie
Copy link
Contributor Author

@amoose thank you 🐲

@adelevie adelevie merged commit a7fcb8f into develop May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants