Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

there's a difference between the numbers on the domains tab and the individual errors page #566

Closed
gbinal opened this issue Sep 22, 2016 · 4 comments

Comments

@gbinal
Copy link
Member

gbinal commented Sep 22, 2016

Compare https://staging.pulse.cio.gov/accessibility/domains/ and https://staging.pulse.cio.gov/accessibility/domain/911.gov#ColorContrastErrors.

@gbinal
Copy link
Member Author

gbinal commented Oct 14, 2016

This is still outstanding, though appears to be based around an incorrect parsing of the error categories. The errors are real but for some reason, some are being mislabeled on the domain page.

screen shot 2016-10-14 at 12 23 15 pm

screen shot 2016-10-14 at 12 23 51 pm

@gbinal
Copy link
Member Author

gbinal commented Feb 16, 2017

I've tried to recreate this by running a scan with just these domains:

  • 911.gov
  • achp.gov
  • acquisition.gov

For aquisition.gov, 1 HTML Attribute error is left out of the domains.json and agencies.json count.
For 911.gov, 1 Color Contrast error is left out of the domains.json and agencies.json count.
For achp.gov, 1 HTML Attribute error is left out of the domains.json and agencies.json count.

In other words, the a11y.json file (and thus the individual domain error pages are correct), while the numbers on the domains and agencies pages are -1. I'm not sure if this is happening every time and it's not a consistent error category or error.

I've got all of the data from these tests. We should go through them in our next coworking session, @micahsaul.

@gbinal
Copy link
Member Author

gbinal commented Feb 23, 2017

Interesting. So, after reordering the a11y.csv file a few times, I realized what's being dropped - the first error.

To sum up, the a11y.json file forms fine, but the domains.json and agencies.json file are always one error low and it's the first error for each domain in the a11y.csv file that gets left out of the count.

In other words, in the a11y.csv file seen below, the errors in rows 2 and 9 will be left out of the count when the domains.json and agencies.json files are generated.

@gbinal
Copy link
Member Author

gbinal commented May 15, 2017

This is done. Thanks, @micahsaul.

@gbinal gbinal closed this as completed May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants