Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Changing 'error' to 'initial findings' in a11y section #609

Closed
gbinal opened this issue Dec 1, 2016 · 7 comments
Closed

Changing 'error' to 'initial findings' in a11y section #609

gbinal opened this issue Dec 1, 2016 · 7 comments
Labels

Comments

@gbinal
Copy link
Member

gbinal commented Dec 1, 2016

No description provided.

@gbinal
Copy link
Member Author

gbinal commented Dec 1, 2016

Here's what I'd suggest, styling wise:

On the domains page, change:

screen shot 2016-12-01 at 1 08 10 pm

to:

screen shot 2016-12-01 at 1 09 41 pm

On the agencies page, change:

screen shot 2016-12-01 at 1 13 21 pm

to:

screen shot 2016-12-01 at 1 13 07 pm

On the individual errors page, change:

screen shot 2016-12-01 at 1 17 31 pm

to:

screen shot 2016-12-01 at 1 18 12 pm

On the guidance page:

Finding and replacing errors with initial findings would impact the readability a good bit. I'd suggest doing a find and replace on the page for errors to findings, which I believe will still read well and wouldn't necessitate rewriting.

@smarina04
Copy link
Contributor

OK, thanks. I do think that it's worth a try, so I appreciate the recommendation.

So, let's replace errors with findings. In places where it currently reads "potential" or "possible" errors, we should replace it with "initial findings." However, for the labels, we can just go with "findings."

@gbinal
Copy link
Member Author

gbinal commented Dec 2, 2016

Alright - @smarina04, this is ready in #610.

I'm going to post screenshots here of what it'd look like. Take a look and holler if you think something should be otherwise.

@gbinal
Copy link
Member Author

gbinal commented Dec 2, 2016

Here's what it's on track to look like.

On the domains page:

screen shot 2016-12-01 at 1 08 10 pm

is set to change to:

screen shot 2016-12-02 at 4 45 33 pm

On the agencies page:

screen shot 2016-12-01 at 1 13 21 pm

is set to change to:

screen shot 2016-12-02 at 4 46 58 pm

On the individual errors page:

screen shot 2016-12-01 at 1 17 31 pm

is set to change to:

screen shot 2016-12-02 at 4 47 48 pm

On the guidance page:

There was one place where potential errors => initial findings. The rest are just a matter of error(s) => finding(s).

@smarina04
Copy link
Contributor

Perfect. Thank you; let's roll with it.

@gbinal
Copy link
Member Author

gbinal commented Dec 7, 2016

I'm going to leave this issue open as we still need to cement the changes.

@gbinal
Copy link
Member Author

gbinal commented Mar 30, 2017

This is now fully addressed and can be closed.

@gbinal gbinal closed this as completed Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants