Fix: Some TS need better typing #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
With this PR we could remove the file in gardens |
tmoutinho
approved these changes
Jan 1, 2022
0xGabi
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aftter the generated d.ts typing version, some components need refactor or make all params optional
It's unlock the 1Hive/gardens-ui#749 of @tmoutinho
Meanwhile its possible use the Gist with already fixed
index.d.tshttps://gist.github.com/kamikazebr/88528d30f2a55eb4ffb49773ea50f13c
place on
node_modules/@1hive/1hive-ui/dist/types/index.d.ts