-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Rewrite types definitions #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, we are doing some tests on a website written in typescript that is working better than the current version that gives problems with components that have props that are required and they should be optional. So I think we can go ahead and merge this.
I also did an overview of the index.d.ts
file and looks fine. I wonder if we could prevent having a super big diff. But I guess not many alternatives.
It's possible split it to each component, the first version using autogenerated made that, so its possible. Knowing that, we will need split each typed component by file and import (merging) in one in index.dt.s in the end. |
List all componens name and status if already converted to ts
https://hackmd.io/y33nfwoTSAiPIm4Efo9kUQ
Aproxx 250 components, all done first phase!
The others phase can be done in nexts PRs
- [ ] Phase 2 - look each component source code and export better typesWaiting for 1Hive/gardens-ui#796How test?
yarn build
./dist/types/index.d.ts
to your gardens-ui project. (eg:gardens-ui/node_modules/@1hive/1hive-ui/dist/types/index.d.ts
yarn build
the gardens-ui project