This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Improve discovery by indexing apps and un-named organisations #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
force-pushed
the
improved-discovery
branch
from
28586e4
to
8d545dd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the discovery mechanism used by the worker and closes #4.
The worker now indexes
This PR also updates Redux Saga to the latest version, streamlining the root saga a bit.
Note that this version of the worker requires
IPFS_URIto be set, since it fetches the artifact and manifest of apps.Furthermore, as of writing this, not all orgs (specifically those without names) have blocks associated with them, so it is not entirely possible to sort based on what block they were created in. I expect to fix this in the next iteration.