Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONT MERGE BEFORE Uniswap and Network] - Token price caching #226

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

Corantin
Copy link
Collaborator

@Corantin Corantin commented Apr 11, 2022

  • Fetch token price only once to limit calls to the API
  • Cache is only loaded until refresh of the page
  • Implement some tests for fetching dashboard info
  • Refactor quest subgraph queries to make them mockable
  • Fix the total funds
    Before :
    image

After :
image

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/quests/4rgK9DKsPrDLdSB6L5cUjvjhUzEX
✅ Preview: https://quests-git-token-price-caching-1hive.vercel.app

@Corantin Corantin changed the base branch from main to fix-uniswap-and-network April 11, 2022 11:18
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #226 (9545f7a) into fix-uniswap-and-network (7b9148c) will not change coverage.
The diff coverage is n/a.

❗ Current head 9545f7a differs from pull request most recent head bb9531b. Consider uploading reports for the commit bb9531b to get more accurate results

@@                    Coverage Diff                    @@
##           fix-uniswap-and-network      #226   +/-   ##
=========================================================
  Coverage                   100.00%   100.00%           
=========================================================
  Files                            2         2           
  Lines                           25        25           
  Branches                         5         5           
=========================================================
  Hits                            25        25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9148c...bb9531b. Read the comment docs.

@Corantin Corantin changed the title Token price caching [DONT MERGE BEFORE Uniswap and Network] - Token price caching Apr 12, 2022
@vercel vercel bot temporarily deployed to Preview April 13, 2022 21:42 Inactive
Base automatically changed from fix-uniswap-and-network to main April 13, 2022 23:00
@kamikazebr
Copy link
Member

Awesome improvment!! <3

@Corantin Corantin merged commit 15d65c5 into main Apr 14, 2022
@Corantin Corantin deleted the token-price-caching branch April 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants