Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper #235

Merged
merged 26 commits into from
Apr 20, 2022
Merged

Stepper #235

merged 26 commits into from
Apr 20, 2022

Conversation

kafann
Copy link
Collaborator

@kafann kafann commented Apr 15, 2022

close #178

@vercel
Copy link

vercel bot commented Apr 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
quests ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 5:03PM (UTC)

@Corantin
Copy link
Collaborator

Corantin commented Apr 16, 2022

Finalement je pensse sa serait plus lisible si c'etait la meme taille de bouton
image

@vercel vercel bot temporarily deployed to Preview April 16, 2022 21:40 Inactive
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #235 (f77b05e) into main (54b3c36) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b3c36...f77b05e. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview April 16, 2022 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2022 22:38 Inactive
@vercel vercel bot temporarily deployed to Preview April 17, 2022 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview April 17, 2022 13:46 Inactive
@vercel vercel bot temporarily deployed to Preview April 17, 2022 13:52 Inactive
Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu pourra merge apres sa, jai fait pas mal de truc dans ta PR mb haha jai add sa :

  • Wallet balance dans quest
  • Disable Create quest button when form invalid
  • Le reste jpensse jte lai dit

packages/react-app/src/components/dashboard.tsx Outdated Show resolved Hide resolved
packages/react-app/src/components/dashboard.tsx Outdated Show resolved Hide resolved
packages/react-app/src/components/modals/quest-modal.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview April 17, 2022 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview April 19, 2022 00:47 Inactive
@vercel vercel bot temporarily deployed to Preview April 19, 2022 02:16 Inactive
@vercel vercel bot temporarily deployed to Preview April 19, 2022 02:34 Inactive
@vercel vercel bot temporarily deployed to Preview April 19, 2022 22:03 Inactive
@vercel vercel bot temporarily deployed to Preview April 19, 2022 22:18 Inactive
@vercel vercel bot temporarily deployed to Preview April 20, 2022 12:08 Inactive
@vercel vercel bot temporarily deployed to Preview April 20, 2022 13:17 Inactive
Copy link
Collaborator

@Corantin Corantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Validate :

  • Stepper in create Quest modal
  • Stepper in Schedule Claim modal
  • Wallet balance is now in create Quest modal and should show a loading feedback
  • Claim list in Quest detail should show loading as well as no content feedback
  • Amount field input should show loading feedback (in placeholder)

@vercel vercel bot temporarily deployed to Preview April 20, 2022 15:39 Inactive
@alexchan0394
Copy link
Collaborator

Wallet balance is now in create Quest modal and should show a loading feedback

When creating a quest, unselecting a token will show loading of the wallet balance when it should be "No Token Selected"

  • Create quest
  • Select a token
  • Deselect token
  • Click BACK
  • Click NEXT
  • You should see no token selected with a loading wallet balance

image

@Corantin
Copy link
Collaborator

Corantin commented Apr 20, 2022

Wallet balance is now in create Quest modal and should show a loading feedback

When creating a quest, unselecting a token will show loading of the wallet balance when it should be "No Token Selected"

Solved by Fix wallet balance loading

@vercel vercel bot temporarily deployed to Preview April 20, 2022 17:03 Inactive
@alexchan0394
Copy link
Collaborator

To Validate :

  • Stepper in create Quest modal
  • Stepper in Schedule Claim modal
  • Wallet balance is now in create Quest modal and should show a loading feedback
  • Claim list in Quest detail should show loading as well as no content feedback
  • Amount field input should show loading feedback (in placeholder)

I checked everything and it should be good to go

@Corantin Corantin merged commit ee48b59 into main Apr 20, 2022
@Corantin Corantin deleted the stepper branch April 20, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants