Transaction index + Back button when transaction

[Corantin]

closes #209

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
quests	✅ Ready (Inspect)	Visit Preview	Apr 20, 2022 at 9:01PM (UTC)

[codecov]

Codecov Report

Merging #241 (b64b8ec) into main (ee48b59) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
  Branches         5         5           
=========================================
  Hits            25        25           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee48b59...b64b8ec. Read the comment docs.

[kamikazebr]

Nice!

---

But

After click in the Back button it return to that screen, its not should close?

[Corantin]

Nice!

But

After click in the Back button it return to that screen, its not should close?

I wanted a back button if per example the transaction failed, to be able to resubmit a new with adjusting some fields.
Do you think it's counter-intuitive? Any suggestions?

[kamikazebr]

I wanted a back button if per example the transaction failed, to be able to resubmit a new with adjusting some fields. Do you think it's counter-intuitive? Any suggestions?

Humm idk. Maybe in the future we can just show back button if it failed? And keep the old data to be adjusted or resend?

yah it's counter intuitive, because the modal can be open for others places and back button looks like we will back there.

Not related but also we can add shortcut for example ESC to close modal will be good improvement immo.

[Corantin]

I can change it to only failed for sure. There is escape to close only when button are modal are focused not inputs

…

On Sun., Apr. 24, 2022, 9:21 a.m. Felipe Novaes F Rocha, < ***@***.***> wrote: I wanted a back button if per example the transaction failed, to be able to resubmit a new with adjusting some fields. Do you think it's counter-intuitive? Any suggestions? Humm idk. Maybe in the future we can just show back button if it failed? And keep the old data to be adjusted or resend? yah it's counter intuitive, because the modal can be open for others places and back button looks like we will back there. Not related but also we can add shortcut for example ESC to close modal will be good improvement immo. — Reply to this email directly, view it on GitHub <#241 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJ7IOSBPL75MK3VNW2CRITVGVDFDANCNFSM5T453DIQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>