quest list is in 2 columns and added useMemo for fakeQuests loading #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexchan0394
commented
Apr 27, 2022
•
alexchan0394
commented
- Make sure they are the same height
- Do not include blocks in the summary view
- Warn Creator for the description that only the first 5 (use var) lines will be displayed in summary view
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 25 25
Branches 5 5
=========================================
Hits 25 25 Continue to review full report at Codecov.
|
Corantin
approved these changes
May 1, 2022
packages/react-app/src/constants.ts
Outdated
| @@ -179,3 +179,5 @@ export const DEFAULT_FILTER = Object.freeze({ | |||
| } as FilterModel); | |||
|
|
|||
| export const DEFAULT_CLAIM_EXECUTION_DELAY_MS = 60 * 15 * 1000; // Add 15 minutes by default | |||
|
|
|||
| export const MAX_LINE_DESCRIPTION = 8; | |||
There was a problem hiding this comment.
Suggested change
| export const MAX_LINE_DESCRIPTION = 8; | |
| export const DEFAULT_DESCRIPTION_MAX_LINE = 5; |
J'ai reussi a get sa so sa prendrai vrmt un height a la place d'un max-height et je laisserait 5 pour maxLine pour que le user puisse deffiler les quests plus vites (chandulu a dit ct important de voir bcp de quest en moins de scroll)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.