Change Govern subgraph to work with GovernQueue only + Add a task to … #266

Corantin · 2022-05-11T21:57:04Z

…deploy GovernQueue

vercel · 2022-05-11T21:57:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
quests	✅ Ready (Inspect)	Visit Preview	May 14, 2022 at 8:07PM (UTC)

…ment

codecov · 2022-05-12T11:41:06Z

Codecov Report

Merging #266 (458b1e5) into main (b71a7a6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           54        56    +2     
  Branches        12        13    +1     
=========================================
+ Hits            54        56    +2

Impacted Files	Coverage Δ
packages/hardhat/contracts/QuestFactory.sol	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71a7a6...458b1e5. Read the comment docs.

packages/hardhat/scripts/deploy-govern_queue.ts

packages/hardhat/hardhat.config.ts

kamikazebr · 2022-05-12T20:45:59Z

packages/react-app/src/networks.ts

+    // questsSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/quests-subgraph',
+    questsSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/quests-subgraph-staging',
+    // governSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/govern-1hive-rinkeby',
+    governSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/govern-1hive-rinkeby-staging',


Maybe we could put it array in the future to easily change beetween subgraphs dependen of network, wdyt?

Its handled like this right now

kamikazebr · 2022-05-12T20:53:50Z

packages/subgraphs/govern-subgraph/manifest/data/rinkeby-staging.json

-{
-  "network": "rinkeby",
-  "dataSources": {
-    "GovernRegistry": [
-      {
-        "name": "GovernRegistry",
-        "address": "0x7a044ff5148220866B9c21E9C6537C7c960eed40",
-        "startBlock": 9932541
-      }
-    ]
-  }
-}


Why you removed that? btw its look almost exactly what i did in quest subgraph, if i knew here it already was there, i could just copy and paste. You ran in some problems to change that?

rinkeby-staging should be the same as rinkeby in my opinion so only one is needed
The only think that should change is the deploy target (corantin/govern-subgraph-rinkeby-staging)

And further more, I dont need Registry I am now only listening on one GovernQueue. Maybe we might want support multiple in the future but right now there is no good reason to drag a GovernRegistry

Corantin · 2022-05-13T02:27:08Z

Oops was supposed to import from other file not declare it haha

…

On Thu., May 12, 2022, 4:31 p.m. Felipe Novaes F Rocha, < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/hardhat/hardhat.config.ts <#266 (comment)>: > +function updateContractResult( + network: Network, + arg1: string, + arg2: { address: string; abi: import("hardhat-deploy/dist/types").ABI } +) { + throw new Error("Function not implemented."); +} Its look imccomplete. — Reply to this email directly, view it on GitHub <#266 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJ7IORRGOJ5PTKLTHCOX6LVJVTCZANCNFSM5VWJYYCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Corantin · 2022-05-13T02:27:44Z

Ohh this is a thing lmao

…

On Thu., May 12, 2022, 4:36 p.m. Felipe Novaes F Rocha, < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/hardhat/hardhat.config.ts <#266 (comment)>: > + defaultConfig.CreateQuestDeposit.xdai.amount, + types.float + ) + .setAction(async (args, hre) => { + const deployResult = await deployQuestFactory(hre, args); + console.log( + "Deployed quest factory (" + hre.network.name + "):", + deployResult.address + ); + updateContractResult(hre.network, "QuestFactory", { + address: deployResult.address, + abi: deployResult.abi, + }); + }); + +task("newQuestFactory:rinkeby") [image: image] <https://user-images.githubusercontent.com/691510/168163457-cced9c62-af85-48ec-bbdd-295599d3041a.png> Maybe you want setDescription for the others task too? — Reply to this email directly, view it on GitHub <#266 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJ7IOQVBV24RI2ONSJQKNDVJVTT7ANCNFSM5VWJYYCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Corantin · 2022-05-13T02:29:07Z

We always need one or the other and the config is already driven by network

…

On Thu., May 12, 2022, 4:46 p.m. Felipe Novaes F Rocha, < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/react-app/src/networks.ts <#266 (comment)>: > + // questsSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/quests-subgraph', + questsSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/quests-subgraph-staging', + // governSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/govern-1hive-rinkeby', + governSubgraph: 'https://api.thegraph.com/subgraphs/name/corantin/govern-1hive-rinkeby-staging', Maybe we could put it array in the future to easily change beetween subgraphs dependen of network, wdyt? — Reply to this email directly, view it on GitHub <#266 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJ7IOVFBQFAG6F2A6ZHKJDVJVUZHANCNFSM5VWJYYCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Corantin · 2022-05-13T02:31:20Z

I just dont need Govern registry right now. In the future, when we will have a registry then we will probably litsten to it but anyway right now the webapp does not support multiple GovernQueue (this is what the Registry allow us to do)

…

On Thu., May 12, 2022, 4:54 p.m. Felipe Novaes F Rocha, < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/subgraphs/govern-subgraph/manifest/data/rinkeby-staging.json <#266 (comment)>: > -{ - "network": "rinkeby", - "dataSources": { - "GovernRegistry": [ - { - "name": "GovernRegistry", - "address": "0x7a044ff5148220866B9c21E9C6537C7c960eed40", - "startBlock": 9932541 - } - ] - } -} Why you removed that? btw its look almost exactly what i did in quest subgraph, if i knew here it already was there, i could just copy and paste. You ran in some problems to change that? — Reply to this email directly, view it on GitHub <#266 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJ7IOTJIYE4ZTNA4LEXTT3VJVVYPANCNFSM5VWJYYCA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

…oy Govern and Quests subgraph

…ardhat-contracts file

into govern-deployment-task

…close)

kamikazebr · 2022-05-14T17:50:32Z

packages/react-app/package.json

@@ -124,6 +124,7 @@
    "start": "cross-env HTTPS=true npm run sync-assets && react-app-rewired start",
    "start:local": "cross-env REACT_APP_CHAIN_ID=1337 yarn start",
    "start:rinkeby": "cross-env REACT_APP_CHAIN_ID=4 yarn start",
+    "start:rinkeby-staging": "cross-env REACT_APP_CHAIN_ID=4 REACT_APP_STAGING=true yarn start",


To who want test it in vercel staging need run that.

Nope vercel always run yarn start and rely on defaultChain and staging variables to decide wich network and environment

kamikazebr · 2022-05-14T17:54:28Z

packages/react-app/src/components/modals/schedule-claim-modal.tsx

+  useEffect(
+    () => () => {
+      mounted = false;
+    },
+    [],
+  );


Mayeb we can open PR to create some hook for it, i saw we have multiples those on the code base.

I was thinking the same but wasnt able to have something cleaner

kamikazebr

Awesome work!

Change Govern subgraph to work with GovernQueue only + Add a task to …

76d1e67

…deploy GovernQueue

vercel bot temporarily deployed to Preview May 11, 2022 21:57 Inactive

Remove useless scripts + add a bunch of script for all in one deploye…

dbbbc9a

…ment

vercel bot temporarily deployed to Preview May 12, 2022 04:40 Inactive

try fix coverage build

42af8b2

vercel bot temporarily deployed to Preview May 12, 2022 11:24 Inactive

Merge branch 'main' into govern-deployment-task

e56ca43

vercel bot temporarily deployed to Preview May 12, 2022 11:30 Inactive

Fix hardcoded path

f6902b9

vercel bot temporarily deployed to Preview May 12, 2022 11:41 Inactive

Hardhat Export to frontend

42a0a1d

vercel bot temporarily deployed to Preview May 12, 2022 12:49 Inactive

Push staging

64b72aa

vercel bot temporarily deployed to Preview May 12, 2022 13:00 Inactive

kamikazebr reviewed May 12, 2022

View reviewed changes

packages/hardhat/scripts/deploy-govern_queue.ts Outdated Show resolved Hide resolved

kamikazebr reviewed May 12, 2022

View reviewed changes

packages/hardhat/hardhat.config.ts Outdated Show resolved Hide resolved

kamikazebr reviewed May 12, 2022

View reviewed changes

packages/hardhat/hardhat.config.ts Show resolved Hide resolved

kamikazebr reviewed May 12, 2022

View reviewed changes

Fix export contracts + GovernSubgraph deploy with .env instead + Depl…

287307f

…oy Govern and Quests subgraph

vercel bot temporarily deployed to Preview May 13, 2022 16:39 Inactive

Fix subgraph + setDescription + remove GovernQueue file as it is in h…

84bd999

…ardhat-contracts file

vercel bot temporarily deployed to Preview May 13, 2022 17:24 Inactive

Push subgraph to skip HNY

b70b63e

fix: schedule gas limit

c592d80

vercel bot temporarily deployed to Preview May 14, 2022 05:28 Inactive

Restore to HNYT

f97fec4

vercel bot temporarily deployed to Preview May 14, 2022 05:35 Inactive

kamikazebr added 2 commits May 14, 2022 02:47

feat: more signatures from abi

b679258

Merge branch 'govern-deployment-task' of https://github.com/1Hive/quests

688bbbc

into govern-deployment-task

vercel bot temporarily deployed to Preview May 14, 2022 05:54 Inactive

feat: addded ANY_ADRESS 0xfff

f7df8aa

vercel bot temporarily deployed to Preview May 14, 2022 06:05 Inactive

Corantin added 2 commits May 14, 2022 02:25

Extract function abi from GovernQueue contract abi file instead

ac6a350

Fix warns

a7c2d17

vercel bot temporarily deployed to Preview May 14, 2022 06:29 Inactive

Bump all gas to 300000 until we have gas optimizer

41f0f90

vercel bot temporarily deployed to Preview May 14, 2022 15:11 Inactive

Bump challenge

c402b14

vercel bot temporarily deployed to Preview May 14, 2022 15:17 Inactive

Fix claim behavior when tx complete (do not update state until modal …

c19b3b4

…close)

vercel bot temporarily deployed to Preview May 14, 2022 16:23 Inactive

kamikazebr reviewed May 14, 2022

View reviewed changes

kamikazebr approved these changes May 14, 2022

View reviewed changes

Deployu Celeste task

92918bf

vercel bot temporarily deployed to Preview May 14, 2022 18:17 Inactive

Corantin added 2 commits May 14, 2022 15:07

Deploy celeste with HNYT + Fix challenge fee hardcoded to HNY

7b7de8e

Fix warns

0c6c3d9

vercel bot temporarily deployed to Preview May 14, 2022 19:12 Inactive

ERC20 -> GovernERC20

458b1e5

vercel bot temporarily deployed to Preview May 14, 2022 20:07 Inactive

Corantin merged commit be57767 into main May 14, 2022

Corantin deleted the govern-deployment-task branch May 14, 2022 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Govern subgraph to work with GovernQueue only + Add a task to … #266

Change Govern subgraph to work with GovernQueue only + Add a task to … #266

Corantin commented May 11, 2022

vercel bot commented May 11, 2022 •

edited

Loading

codecov bot commented May 12, 2022 •

edited

Loading

kamikazebr May 12, 2022

Corantin May 13, 2022

kamikazebr May 12, 2022

Corantin May 13, 2022 •

edited

Loading

Corantin May 13, 2022

Corantin commented May 13, 2022 via email

Corantin commented May 13, 2022 via email

Corantin commented May 13, 2022 via email

Corantin commented May 13, 2022 via email

kamikazebr May 14, 2022

Corantin May 14, 2022

kamikazebr May 14, 2022

Corantin May 14, 2022

kamikazebr left a comment

Change Govern subgraph to work with GovernQueue only + Add a task to … #266

Change Govern subgraph to work with GovernQueue only + Add a task to … #266

Conversation

Corantin commented May 11, 2022

vercel bot commented May 11, 2022 • edited Loading

codecov bot commented May 12, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Corantin May 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Corantin commented May 13, 2022 via email

Corantin commented May 13, 2022 via email

Corantin commented May 13, 2022 via email

Corantin commented May 13, 2022 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kamikazebr left a comment

Choose a reason for hiding this comment

vercel bot commented May 11, 2022 •

edited

Loading

codecov bot commented May 12, 2022 •

edited

Loading

Corantin May 13, 2022 •

edited

Loading