-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up CD to release to GitHub Pages #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To maintain backwards compatibility.
thatguygriff
previously approved these changes
May 3, 2021
To avoid unwanted release attempts. More background in the upstream PR: helm/chart-releaser-action#80
We should wait with merging this until the next release is prepped, because otherwise it'll try to re-release v1.1.0. So converting to a draft for now to avoid an accidental merge. |
We can revert this after the next version bump
I've disabled the automatic workflow trigger, so we can already merge this. |
thatguygriff
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CD pipeline for the Helm chart and also transitions the Helm repo model to use GitHub Pages.
Impact of this transition on the Git repo and on the Helm repo:
New Helm repo url
https://raw.githubusercontent.com/1Password/connect-helm-charts/main
https://1password.github.io/connect-helm-charts
No more generated files / artifacts in source control
With the new model, we can remove the
.tgz
files and theindex.yaml
file. For backwards compatibility, I didn't remove theindex.yaml
file just yet (which I will in a future PR). Instead, I've changed the tar urls it points to, so that old repo url still works without the tars in source control anymore.GitHub Pages setup
Here's how this works: there's now a persistent branch called
gh-pages
, whose file tree gets served by GitHub Pages. It only has anindex.yaml
file (served athttps://1password.github.io/connect-helm-charts/index.yaml
), because that's all Helm needs. The index file points to tars stored as GitHub Release assets. For backwards compatibility, I've manually uploaded the existing tars to the corresponding GitHub Release.New release process and tagging model
To do the release, we're using the official Helm
chart-releaser
CLI and accompanying action. This will keep an eye onmain
for new chart versions (i.e. different version inChart.yaml
compared to the previous chart tag) and automatically create a new tag+release on GitHub with the tar. Then, it updates theindex.yaml
file on thegh-pages
branch.Using the
chart-releaser
tooling does impose some differences to the way we've done things before, noticeably:<chart name>-<chart version>
. Here's an example of how that will look (this was done on a fork):connect/
tocharts/connect/