Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Workspace beta capability #64

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

alicethorne-ab
Copy link
Contributor

@alicethorne-ab alicethorne-ab commented Jun 8, 2022

Adds Workspace beta features.

Primarily, it refactors how credentials are stored or accessed within Kubernetes, and defines OP_WORKSPACE_CREDENTIALS and OP_WORKSPACE_SETTINGS with the appropriate paths. Some slight refactoring had to occur to make it more able to handle these additions.

I also fixed a few odd things I found along the way; the largest of these small fixes including upgrading the redis container's chart, as it was required to pass CI.

@alicethorne-ab alicethorne-ab force-pushed the alice/workspace-beta branch 2 times, most recently from 6388976 to 00f966d Compare June 9, 2022 23:39
Copy link
Member

@grellyd grellyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Testing wise, the testing steps here are to run the new helm chart with workspace enabled, correct? Is there anything else I should be doing to validate this work?

op-scim-bridge/templates/deployment.yaml Show resolved Hide resolved
@laughingman-hass laughingman-hass merged commit 57173f3 into main Jun 17, 2022
@laughingman-hass laughingman-hass deleted the alice/workspace-beta branch June 17, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants