Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Rust 1.57 MSRV #129

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Force Rust 1.57 MSRV #129

merged 1 commit into from
Jul 13, 2023

Conversation

czocher
Copy link
Contributor

@czocher czocher commented Jun 19, 2023

This PR forces the CI as well as local dev environments to use Rust 1.57, which is the MSRV for this project.

Closes #94

@czocher czocher force-pushed the force-msrv branch 5 times, most recently from 206d180 to 6b262e5 Compare June 19, 2023 20:32
@czocher
Copy link
Contributor Author

czocher commented Jun 19, 2023

@CerulanLumina what do we do about the clippy errors for MSRV? My suggestion is to use the stable version for clippy.

@LuminaSapphira
Copy link
Collaborator

Clippy on stable should be fine. Any MSRV issues should be caught by the rest of the toolchain, and it seems using an updated clippy should only allow the extra indirection we have in topsort.

Thanks for working this, we appreciate your contributions!

@czocher czocher force-pushed the force-msrv branch 4 times, most recently from c80110f to cd4879d Compare June 20, 2023 18:36
@czocher
Copy link
Contributor Author

czocher commented Jun 20, 2023

I changed it to validate with stable but also added an allow so that it won't bother people on their local environments.

@Lucretiel
Copy link
Contributor

Thanks for the contribution! I'm worried about forcing all uses of this library to use 1.57, even local development builds (as opposed to using it only as part of a CI matrix). I'll ask the rest of the typeshare team and get back to you.

@czocher
Copy link
Contributor Author

czocher commented Jun 24, 2023

@Lucretiel I implemented the dev change due to the task mentioned in #94, but if that's not necessary I can remove the local dev part of this PR ;).

@Lucretiel
Copy link
Contributor

I spoke with the team and apparently I was just mistaken, these changes look good! I'm giving it a final lookover then we should be able to merge today

@czocher czocher force-pushed the force-msrv branch 2 times, most recently from 6d55389 to 7bae69c Compare July 1, 2023 10:33
@Lucretiel Lucretiel merged commit 20a8161 into 1Password:main Jul 13, 2023
@Lucretiel
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve recurring MSRV issues
3 participants