Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CTAssetsGridViewController.m [self setupButtons] from viewDidLoad to viewWillAppear #178

Closed
germs5 opened this issue Nov 19, 2015 · 0 comments

Comments

@germs5
Copy link

germs5 commented Nov 19, 2015

I was trying to set my own value for the Done button text throughout the library, by referring to a property that I added to CTAssetsPickerController.h. However, self.picker evaluates to nil in the setupButtons method, as CTAssetsGridViewController has not yet been placed in the view controller hierarchy. Setting the action for a nil target works anyway, probably due to run-time searching for a view controller that responds to the action. So this is a low priority change. However, this a bug waiting to happen. Maybe other view controllers have this same problem.

@germs5 germs5 changed the title Move CTAssetsGridViewController.m [self setupButtons] from viewDidLoad to viewWillAppea Move CTAssetsGridViewController.m [self setupButtons] from viewDidLoad to viewWillAppear Nov 19, 2015
1and2papa added a commit that referenced this issue Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants