Данные о защищенных, запароленных модулях #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
рефакторинг метода computeModules #3076
nixel2007
reviewed
Jun 21, 2023
| @@ -335,5 +360,8 @@ protected void checkChild(MdoReference parentMdoReference, | |||
| protected static Path getMDOPathDesigner(String path) { | |||
| return Paths.get(SRC_DESIGNER, path); | |||
| } | |||
| protected static Path getMDOPathDesigner(String path, String rootPath) { | |||
There was a problem hiding this comment.
@theshadowco обрати внимание
тут вообще хочется отрефакторить, привести вызовы всех похожих методов модуля к вызову общих модулей
- getMDOPathDesigner(String path, String rootPath)
- getMDOPathEDT(String path, String rootPath)
|
Я проверил, у меня все тесты прошли, кроме, конечно, проверки лицензии (год не тот во всех модулях, не только в моем коде) |
|
Уточню - у меня успешно прошли тесты всего проекта, а не только мои тесты из МР |
рефакторинг
исправил расположение тест.данных рефакторинг
6 tasks
|
@theshadowco посмотри, доработка готова - Данные о защищенных, запароленных модулях |
|
@artbear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Для реализации 1c-syntax/bsl-language-server#3076
Описание
неожиданно для них отдельная обработка
выделил отдельную задачу [NEW] Данные о защищенных, запароленных модулях внутри внешних отчетов и обработок #415
Связанные задачи
Closes #414
Чеклист
Общие
gradlew precommit)Дополнительно